Replaced $.browser as deprecated in jQuery 1.9 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to use this with jQuery 1.10, and $.browser was deprecated in jQuery 1.9. Replaced $.browser.msie with /MSIE/.test(navigator.userAgent)
|
I think #30 is a better solution. |
|
Ok, browser detection is bad, really you should detect features instead. The reason why is that old browsers may be patched and browsers you've never seen before may have the same issue. Unfortunately here we're patching for specific buggy behaviour in IE6 & 7 where they can use an iframe to shim history handling - I've no idea how to test for that. #30 is a terrible solution - it replaces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to use this with jQuery 1.10, and $.browser was deprecated in jQuery 1.9.
Replaced $.browser.msie with /MSIE/.test(navigator.userAgent)