Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Prototype Pollution in handlebars < 4.7.7: CVE-2021-23383 #56

Open
ddalcino opened this issue Jan 2, 2024 · 0 comments
Open

Comments

@ddalcino
Copy link

ddalcino commented Jan 2, 2024

Quote from GH security advisory for CVE-2021-23383, first reported on May 4, 2021:

The package handlebars before 4.7.7 are vulnerable to Prototype Pollution when selecting certain compiling options to compile templates coming from an untrusted source.

GHSA has scored this a 9.8/10 (Critical).

I'm opening this issue as a sort of PSA, in case anyone is still using this gem as-is. It probably would not be too difficult to fix this (just update the gemspec to allow handlebars-source '~>4.7.7'), but since this gem hasn't been updated in 9 years I don't expect that's going to happen.

As stated in the readme, "In general, you should not trust user-provided templates", and if you're doing that, this CVE likely won't affect you. On the other hand, if you are depending on using user-provided templates, you should be aware that this CVE (and a dozen more, see: https://security.snyk.io/vuln/npm?search=handlebars) could affect you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant