fix: cicd job names and variable declarations

Co-authored-by: Federico Giacon <[email protected]>
cowprotocol · Jun 3, 2024 · 0dfa587 · 0dfa587
1 parent 8487ff6
commit 0dfa587
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/.github/workflows/gas.yml b/.github/workflows/gas.yml
@@ -18,7 +18,7 @@ env:
   FOUNDRY_PROFILE: ci
 
 jobs:
-  tests:
+  gas:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -27,7 +27,7 @@ jobs:
 
       - uses: actions/setup-node@v4
       - id: yarn-cache
-        run: echo "::set-output name=dir::$(yarn cache dir)"
+        run: echo "dir=$(yarn cache dir)"  >> "$GITHUB_OUTPUT"
       - uses: actions/cache@v4
         with:
           path: ${{ steps.yarn-cache.outputs.dir }}

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -18,7 +18,7 @@ env:
   FOUNDRY_PROFILE: ci
 
 jobs:
-  tests:
+  lint:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -27,7 +27,7 @@ jobs:
 
       - uses: actions/setup-node@v4
       - id: yarn-cache
-        run: echo "::set-output name=dir::$(yarn cache dir)"
+        run: echo "dir=$(yarn cache dir)"  >> "$GITHUB_OUTPUT"
       - uses: actions/cache@v4
         with:
           path: ${{ steps.yarn-cache.outputs.dir }}

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -3,8 +3,6 @@ name: Test
 on:
   workflow_dispatch:
   pull_request:
-    branches:
-      - main
     paths:
       - '**.sol'
       - '**.yml'
@@ -19,7 +17,7 @@ env:
   FOUNDRY_PROFILE: ci
 
 jobs:
-  check:
+  test:
     strategy:
       fail-fast: true
 
@@ -32,7 +30,7 @@ jobs:
 
       - uses: actions/setup-node@v4
       - id: yarn-cache
-        run: echo "::set-output name=dir::$(yarn cache dir)"
+        run: echo "dir=$(yarn cache dir)"  >> "$GITHUB_OUTPUT"
       - uses: actions/cache@v4
         with:
           path: ${{ steps.yarn-cache.outputs.dir }}

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,5 +1,4 @@
 {
-  "editor.formatOnSave": true,
   "solidity.packageDefaultDependenciesContractsDirectory": "src/contracts/",
   "solidity.packageDefaultDependenciesDirectory": "lib",
   "[solidity]": {