From 0dfa587e9f72d982bafbc615ff5999f906af1fca Mon Sep 17 00:00:00 2001
From: mfw78 <53399572+mfw78@users.noreply.github.com>
Date: Mon, 3 Jun 2024 16:05:42 +0000
Subject: [PATCH] fix: cicd job names and variable declarations

Co-authored-by: Federico Giacon <58218759+fedgiac@users.noreply.github.com>
---
 .github/workflows/gas.yml  | 4 ++--
 .github/workflows/lint.yml | 4 ++--
 .github/workflows/test.yml | 6 ++----
 .vscode/settings.json      | 1 -
 4 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/gas.yml b/.github/workflows/gas.yml
index 913762fb..4f42baf1 100644
--- a/.github/workflows/gas.yml
+++ b/.github/workflows/gas.yml
@@ -18,7 +18,7 @@ env:
   FOUNDRY_PROFILE: ci
 
 jobs:
-  tests:
+  gas:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -27,7 +27,7 @@ jobs:
 
       - uses: actions/setup-node@v4
       - id: yarn-cache
-        run: echo "::set-output name=dir::$(yarn cache dir)"
+        run: echo "dir=$(yarn cache dir)"  >> "$GITHUB_OUTPUT"
       - uses: actions/cache@v4
         with:
           path: ${{ steps.yarn-cache.outputs.dir }}
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index dd0f1b5c..7a491d9c 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -18,7 +18,7 @@ env:
   FOUNDRY_PROFILE: ci
 
 jobs:
-  tests:
+  lint:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -27,7 +27,7 @@ jobs:
 
       - uses: actions/setup-node@v4
       - id: yarn-cache
-        run: echo "::set-output name=dir::$(yarn cache dir)"
+        run: echo "dir=$(yarn cache dir)"  >> "$GITHUB_OUTPUT"
       - uses: actions/cache@v4
         with:
           path: ${{ steps.yarn-cache.outputs.dir }}
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index a399947d..4ce078d9 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -3,8 +3,6 @@ name: Test
 on:
   workflow_dispatch:
   pull_request:
-    branches:
-      - main
     paths:
       - '**.sol'
       - '**.yml'
@@ -19,7 +17,7 @@ env:
   FOUNDRY_PROFILE: ci
 
 jobs:
-  check:
+  test:
     strategy:
       fail-fast: true
 
@@ -32,7 +30,7 @@ jobs:
 
       - uses: actions/setup-node@v4
       - id: yarn-cache
-        run: echo "::set-output name=dir::$(yarn cache dir)"
+        run: echo "dir=$(yarn cache dir)"  >> "$GITHUB_OUTPUT"
       - uses: actions/cache@v4
         with:
           path: ${{ steps.yarn-cache.outputs.dir }}
diff --git a/.vscode/settings.json b/.vscode/settings.json
index 90a26dd7..35c0a72a 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -1,5 +1,4 @@
 {
-  "editor.formatOnSave": true,
   "solidity.packageDefaultDependenciesContractsDirectory": "src/contracts/",
   "solidity.packageDefaultDependenciesDirectory": "lib",
   "[solidity]": {