tests(core): GPv2TradeSimulator
#122
Assignees
Labels
E:5.2 Contracts migrations
See https://github.com/cowprotocol/pm/issues/32 for details
help wanted
Extra attention is needed
test
Issue related to the test suite with no expected consequence to production code
Comments
mfw78
added
help wanted
|
Hey @mfw78 i would like to contribute to the issue , could you please provide contribution guidelines |
|
Hello yomanthunder and thanks for your interest! mfw78 already started working on this. In the end, we were considering getting rid of the contract We don't have formal contribution guidelines but we're considering introducing them. If you have some specific ideas on what you want to see on them, please comment in the dedicated issue. |
fedgiac
added a commit
that referenced
this issue
Aug 15, 2024
## Description I don't think we've ever made use of the trade simulator. It was an interesting way to showcase the `StorageAccessible` contract, but had limited practical use: every time we need to simulate a trade, we just simulate a full settlement. The related code is therefore removed for the sake of simplification. [Internal discussion](https://cowservices.slack.com/archives/C0375NV72SC/p1723468371629409) didn't bring up any use for it. As mentioned in commit 5475208, `test/src/GPv2SettlementTestInterface.sol` was only needed because of the trade simulator tests and can now be removed as well. ## Test Plan CI. ## Related Issues Closes #122 as not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: