Deprecation notice for the NPM package #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Deployed contracts in Base chain. Settlement contract: https://basescan.org/address/0x9008D19f58AAbD9eD0D60971565AA8510560ab41 Verified all contracts in Tenderly ✔️ Verified all contracts except `EIP173Proxy` in Basescan.
shoom3301
approved these changes
Dec 5, 2024
anxolin
approved these changes
Dec 5, 2024
anxolin
reviewed
Dec 5, 2024
There was a problem hiding this comment.
@fedgiac you might want to deprecate like this https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions
I'd first wait for when the SDK doesn't depend on it anymore, but otherwise I agree we should do the deprecation through NPM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds deprecation warning for
@cowprotocol/contractsNPM package.