Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dynamically pull ABI from upstream #142

Closed
mfw78 opened this issue Aug 15, 2023 · 1 comment
Closed

chore: dynamically pull ABI from upstream #142

mfw78 opened this issue Aug 15, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mfw78
Copy link
Contributor

mfw78 commented Aug 15, 2023

Problem

The ABI that is used to generate the contracts should not be duplicated in the repository, but instead consumed from upstream.

Solution

Add the contract's ABI via a dev dependency NPM package, and then use this for the typechain generation.

Blockers

@mfw78 mfw78 mentioned this issue Aug 15, 2023
1 task
@mfw78 mfw78 added the enhancement New feature or request label Aug 15, 2023
@mfw78 mfw78 mentioned this issue Aug 22, 2023
@mfw78 mfw78 self-assigned this Aug 22, 2023
@mfw78
Copy link
Contributor Author

mfw78 commented Aug 22, 2023

Will close this, and cow-sdk can choose explicitly which ABI to import. If required, an NPM package such as cowprotocol/composable-cow#60 can be used if requiring bulk ABI.

@mfw78 mfw78 closed this as completed Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant