fix: prices must be in Fraction before division

cowprotocol · Jan 16, 2025 · 4903127 · 4903127
1 parent d672231
commit 4903127
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/apps/cowswap-frontend/src/common/updaters/orders/SpotPricesUpdater.ts b/apps/cowswap-frontend/src/common/updaters/orders/SpotPricesUpdater.ts
@@ -87,7 +87,9 @@ export function SpotPricesUpdater(): null {
         return
       }
 
-      const fraction = inputPrice.price.divide(outputPrice.price)
+      const inputFraction = FractionUtils.fractionLikeToFraction(inputPrice.price)
+      const outputFraction = FractionUtils.fractionLikeToFraction(outputPrice.price)
+      const fraction = inputFraction.divide(outputFraction)
 
       if (!fraction) {
         return

diff --git a/apps/cowswap-frontend/src/modules/limitOrders/hooks/useGetInitialPrice.ts b/apps/cowswap-frontend/src/modules/limitOrders/hooks/useGetInitialPrice.ts
@@ -1,6 +1,6 @@
 import { useEffect, useState } from 'react'
 
-import { getWrappedToken } from '@cowprotocol/common-utils'
+import { FractionUtils, getWrappedToken } from '@cowprotocol/common-utils'
 import { Fraction } from '@uniswap/sdk-core'
 
 import { useAsyncMemo } from 'use-async-memo'
@@ -32,7 +32,9 @@ export function useGetInitialPrice(): { price: Fraction | null; isLoading: boole
       if (!inputUsdPrice?.price || !outputUsdPrice?.price) {
         return null
       }
-      return inputUsdPrice.price.divide(outputUsdPrice.price)
+      const inputFraction = FractionUtils.fractionLikeToFraction(inputUsdPrice.price)
+      const outputFraction = FractionUtils.fractionLikeToFraction(outputUsdPrice.price)
+      return inputFraction.divide(outputFraction)
     },
     [inputUsdPrice?.price, outputUsdPrice?.price],
     null,