fix(hooks-store): log simulation only on trade simulation (#5101)

cowprotocol · Nov 18, 2024 · 84f5d5e · 84f5d5e
1 parent 5c3881f
commit 84f5d5e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/apps/cowswap-frontend/src/common/containers/OrderHooksDetails/index.tsx b/apps/cowswap-frontend/src/common/containers/OrderHooksDetails/index.tsx
@@ -18,9 +18,10 @@ interface OrderHooksDetailsProps {
   appData: string | AppDataInfo
   children: (content: ReactElement) => ReactElement
   margin?: string
+  isTradeConfirmation?: boolean
 }
 
-export function OrderHooksDetails({ appData, children, margin }: OrderHooksDetailsProps) {
+export function OrderHooksDetails({ appData, children, margin, isTradeConfirmation }: OrderHooksDetailsProps) {
   const [isOpen, setOpen] = useState(false)
   const appDataDoc = useMemo(() => {
     return typeof appData === 'string' ? decodeAppData(appData) : appData.doc
@@ -33,14 +34,14 @@ export function OrderHooksDetails({ appData, children, margin }: OrderHooksDetai
   const { mutate, isValidating, data } = useTenderlyBundleSimulation()
 
   useEffect(() => {
-    mutate()
-  }, []) // eslint-disable-line react-hooks/exhaustive-deps
+    if (isTradeConfirmation) mutate()
+  }, [isTradeConfirmation, mutate])
 
   if (!appDataDoc) return null
 
   const metadata = appDataDoc.metadata as latest.Metadata
 
-  const hasSomeFailedSimulation = Object.values(data || {}).some((hook) => !hook.status)
+  const hasSomeFailedSimulation = isTradeConfirmation && Object.values(data || {}).some((hook) => !hook.status)
 
   const preHooksToDapp = matchHooksToDappsRegistry(metadata.hooks?.pre || [], preCustomHookDapps)
   const postHooksToDapp = matchHooksToDappsRegistry(metadata.hooks?.post || [], postCustomHookDapps)
@@ -76,8 +77,8 @@ export function OrderHooksDetails({ appData, children, margin }: OrderHooksDetai
       </styledEl.Summary>
       {isOpen && (
         <styledEl.Details>
-          <HooksInfo data={preHooksToDapp} hooks={hooks.preHooks} title="Pre Hooks" />
-          <HooksInfo data={postHooksToDapp} hooks={hooks.postHooks} title="Post Hooks" />
+          <HooksInfo data={preHooksToDapp} hooks={isTradeConfirmation ? hooks.preHooks : []} title="Pre Hooks" />
+          <HooksInfo data={postHooksToDapp} hooks={isTradeConfirmation ? hooks.postHooks : []} title="Post Hooks" />
         </styledEl.Details>
       )}
     </styledEl.Wrapper>,

diff --git a/apps/cowswap-frontend/src/modules/trade/pure/TradeConfirmation/index.tsx b/apps/cowswap-frontend/src/modules/trade/pure/TradeConfirmation/index.tsx
@@ -127,7 +127,13 @@ export function TradeConfirmation(props: TradeConfirmationProps) {
   }
 
   const hookDetailsElement = (
-    <>{appData && <OrderHooksDetails appData={appData}>{(hookChildren) => hookChildren}</OrderHooksDetails>}</>
+    <>
+      {appData && (
+        <OrderHooksDetails appData={appData} isTradeConfirmation>
+          {(hookChildren) => hookChildren}
+        </OrderHooksDetails>
+      )}
+    </>
   )
 
   return (