Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multisig/Safe: Increase default deadline #208

Closed
anxolin opened this issue Apr 2, 2022 · 3 comments
Closed

Multisig/Safe: Increase default deadline #208

anxolin opened this issue Apr 2, 2022 · 3 comments
Labels
app:CowSwap CowSwap app Enhancement New feature or request Medium Severity indicator. It causes some undesirable behavior, but the system is still functional UX Debt UX issues that aren't sexy enough for the roadmap

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 2, 2022 •
edited
Loading

Describe the feature

As a multisig user, I would like to have better deadline defaults for order creation, so even if I'm not aware on how to change the deadline, or if I forget to do so, I get more time to sign my orders

Why should we build it (Impact)?

  • Prevent expirations for multisig orders --> More active COW liquidity, potentially big trades
  • Reduced cases of frustration due to expiring orders: Collecting signatures takes time

Who are we building it for?

multisig users

Any additional context or examples

Similar to how we modify the slippage for ETH Flow, we can have a setting for "Multisig Deadline" independent from the "EOA Deadline" with a different value (and default).
@anxolin anxolin added Medium Severity indicator. It causes some undesirable behavior, but the system is still functional app:CowSwap CowSwap app Enhancement New feature or request labels Apr 2, 2022
@elena-zh elena-zh reopened this Jan 18, 2023
@elena-zh
Copy link
Contributor

We have issues reported by users about it https://discord.com/channels/869166959739170836/869170255266734103/1069985893429026847

@anxolin anxolin changed the title Settings: Increase transaction deadline time Multisig/Safe: Increase default deadline Feb 14, 2023
@anxolin
Copy link
Contributor Author

anxolin commented May 5, 2023

I think is a good moment for tackling this one!

What about going with the maximum with Safes? (180min)

A second thing we should really do is this:
image

Otherwise, DAOs or users think they can't place an order for longer than 180min

@tukantje tukantje self-assigned this May 15, 2023
@elena-zh elena-zh mentioned this issue May 22, 2023
Closed
@MindyCoW MindyCoW added the UX Debt UX issues that aren't sexy enough for the roadmap label May 22, 2023
This was referenced Oct 16, 2024
Merged
Merged
@elena-zh
Copy link
Contributor

Done: 12 hours for SC wallets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Enhancement New feature or request Medium Severity indicator. It causes some undesirable behavior, but the system is still functional UX Debt UX issues that aren't sexy enough for the roadmap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anxolin @tukantje @elena-zh @MindyCoW