Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe: duplicating token pop-up does not appear -> impossible to pick a token #2551

Closed
elena-zh opened this issue May 25, 2023 · 2 comments
Closed
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

Similar to #2365

  1. On the Mainnet, open Safe app
  2. Open CoW Swap inside the Safe
  3. Search for 'AURA' token in the token list
  4. Select the one that needs to be imported (!!!)

AR: no duplicating token warning, the token is not picked
image.png
safe.png
ER: there should be a duplicating token warning

@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system labels May 25, 2023
@anxolin
Copy link
Contributor

anxolin commented Jun 5, 2023

What should we do in this case? Do we want to prevent to use two tokens with the same symbol? Wouldn't we need to offer at least a way to rename them or something to have such a restriction?

@elena-zh
Copy link
Author

@anxolin

What should we do in this case? Do we want to prevent to use two tokens with the same symbol? Wouldn't we need to offer at least a way to rename them or something to have such a restriction?

as the issue is similar to #2365, we need to add our modal in order to make it work in Safe wallet. Warning should look like this
image

the root cause of the issue is that this warning
image

does not work in Safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Development

No branches or pull requests

2 participants