Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[solver-competition] Explorer: Show solver competition page #3720

Closed
anxolin opened this issue May 5, 2022 · 7 comments
Closed

[solver-competition] Explorer: Show solver competition page #3720

anxolin opened this issue May 5, 2022 · 7 comments
Assignees

Comments

@anxolin
Copy link
Contributor

anxolin commented May 5, 2022

As a user of the explorer,
I want to see the current state on the solving competition,
So I:

  • Can understand better how the solvers compete to find the best solutions
  • Can I can see if the solution has been already proposed, and if the transaction is being mined
  • Can see the latest batches

I might be interested in showing some general stats on surplus

TBD:

  • Mockups
  • How can we explain the objective function, so is, well... objective?
  • Can we link this to the rules of the game?
  • Should we have a banner advertising on how to become a solver?

Additional details

Related to backend API proposal cowprotocol/services#187

@anxolin anxolin changed the title Show solver competition page [solver-competition] Explorer: Show solver competition page May 5, 2022
@anxolin anxolin added the Epic label May 5, 2022
@anxolin anxolin added the app:CowSwap CowSwap app label May 5, 2022
@alfetopito alfetopito transferred this issue from cowprotocol/cowswap May 17, 2022
@alongoni alongoni self-assigned this Oct 6, 2022
@alongoni
Copy link
Contributor

The following is a first draft to represent some data related to solver competitions:

  1. "Solver competition" tab added on Transaction Details page
    UI_Explorer-Solver-Competition-1

  2. "Current auction" added on Solvers page.
    UI_Explorer-Solver-Competition-2

cc @alfetopito @ramirotw

@elena-zh
Copy link

Hey @alongoni , great job!

I'm not sure about this, but I'd like to add some my proposals to the mock-ups.

  1. I think, that the tab name should be in plural - Current auctions
    auctions
  2. Then, I think, it would be great to add a card/easy navigation to this page from the Home page, WDYT?
    curr
  3. I also think it would be great to add a menu dropdown to the Solvers page to open Solvers table tabs directly
    menu
  4. Maybe we should move 'Objective' to the left and display it under the Solutions table name?
    objective
  5. Current auctions: maybe we should add an order status in each line (opened/filled)? And for the filled orders show a TX link with easy navigation to Solver competitions page? In order to accomodate all these additional columns to the table area we could reduce Date column, as an example. WDYT?

Again, I do not have a strong opinion on the items I listed. Let wait till the team reviews it.

Thanks!

@alfetopito
Copy link
Collaborator

Adding here what I mentioned during our sync call:

For a given settlement:

  1. Take into account that there might be several orders matched. That means, many prices as well as many orders to display which wouldn't fit the regular design
  2. Display also in the overview (abbreviated) call data with a copy button and link to tenderly simulation (if possible)
  3. Make every solution row expandable, with the pertinent info: orders, prices, call data like in the overview
  4. Link somehow in the object helper/somewhere else to the object function docs
  5. Add units where it's reasonable: Fees (ETH), Cost (I assume ETH), Gas (I assume GWEI)

For Current auction:

  1. Agustin/Ramiro proposed a toggle OR play/pause button to make page auto-update
  2. Add to the type column a label: SWAP | LIMIT | LIQUITIY - not closed on this, feel free to experiment

@alongoni
Copy link
Contributor

Design updated:

For a given settlement:
UI_Explorer-Solver-Competition-1
UI_Explorer-Solver-Competition-1-1
@alfetopito Can you give us more context regarding this comment :

Take into account that there might be several orders matched. That means, many prices as well as many orders to display which wouldn't fit the regular design

For Current auction (two variants to control the running updates):

UI_Explorer-Solver-Competition-2
UI_Explorer-Solver-Competition-2-1

@alongoni
Copy link
Contributor

@alfetopito Maybe this design could work better when we have many orders:
UI_Explorer-Solver-Competition-1

@alongoni
Copy link
Contributor

Design file: https://www.figma.com/file/Y7pY6gGH2Wss6qhJwVcDJk/CoW-Explorer-(migrated)?node-id=2905%3A4493

@alfetopito alfetopito assigned alfetopito and unassigned alongoni Oct 31, 2022
@elena-zh elena-zh transferred this issue from cowprotocol/explorer Jan 26, 2024
@elena-zh elena-zh added Explorer and removed app:CowSwap CowSwap app labels Jan 26, 2024
@elena-zh
Copy link

Closing for now: can be reopened when re-prioritized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants