Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom hook: wrong validation message when something is wrong with a hook's link #5116

Closed
elena-zh opened this issue Nov 20, 2024 · 1 comment
Closed

Custom hook: wrong validation message when something is wrong with a hook's link #5116

elena-zh opened this issue Nov 20, 2024 · 1 comment
Labels
Bug Something isn't working Hooks store Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link
Contributor

elena-zh commented Nov 20, 2024 •
edited
Loading

  1. Open Hooks page in a mobile view
  2. Press on the Add post-hook tab
  3. Move to the My custom hooks tab --> press on the Add custom hook button
  4. Fill in this URL: https://cow-hooks-dapps-cow-amm-deposit.verce.app/ (here 'l' is missing in the 'vercel' word)

AR: validation message that does not explain anything is displayed
image

ER: we should let a user know that the link is broken
@elena-zh elena-zh added Bug Something isn't working Hooks store labels Nov 20, 2024
@fairlighteth fairlighteth mentioned this issue Nov 20, 2024
Merged
@elena-zh elena-zh changed the title Custom hook: wrong validation message when '/' in the end of a hook's link Custom hook: wrong validation message when something is wrong with a hook's link Nov 20, 2024
@elena-zh elena-zh added the Low Severity indicator for defects. It won't cause any major break-down of the system label Nov 20, 2024
@fairlighteth fairlighteth mentioned this issue Nov 21, 2024
Merged
@elena-zh
Copy link
Contributor Author

Fixed in #5123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Hooks store Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elena-zh