Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit: price is recalculated after user's input #5165

Closed
elena-zh opened this issue Dec 6, 2024 · 0 comments · Fixed by #5232
Closed

Limit: price is recalculated after user's input #5165

elena-zh opened this issue Dec 6, 2024 · 0 comments · Fixed by #5232
Labels
Bug Something isn't working limit-order Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link

elena-zh commented Dec 6, 2024

This feedback: https://cowservices.slack.com/archives/C03S445V822/p1733473661379419

  1. Open limit orders
  2. Select a token pair, an amount to trade
  3. Change a limit price
  4. Wait a bit (up to 5 minutes)

AR: the price might be changed!

ER: the price should not be changed if a user updated it.
@elena-zh elena-zh added Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional limit-order labels Dec 6, 2024
@shoom3301 shoom3301 mentioned this issue Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working limit-order Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(limit-orders): do not override user entered price cowprotocol/cowswap
1 participant
@elena-zh