Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix failed e2e test #5257

Merged
merged 1 commit into from
Dec 25, 2024
Merged

chore: fix failed e2e test #5257

merged 1 commit into from
Dec 25, 2024

Conversation

shoom3301
Copy link
Collaborator

Summary

The case on the picture bellow is always failed.
It's actually has wrong URL setup. If you want to specify only buyAmount you have to set orderKind parameter as well.

image

Test

All e2e tests should be green

@shoom3301 shoom3301 requested review from a team December 25, 2024 10:39
@shoom3301 shoom3301 self-assigned this Dec 25, 2024
Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 25, 2024 10:52am
cowfi ✅ Ready (Inspect) Visit Preview Dec 25, 2024 10:52am
explorer-dev ✅ Ready (Inspect) Visit Preview Dec 25, 2024 10:52am
sdk-tools ✅ Ready (Inspect) Visit Preview Dec 25, 2024 10:52am
swap-dev ✅ Ready (Inspect) Visit Preview Dec 25, 2024 10:52am
widget-configurator ✅ Ready (Inspect) Visit Preview Dec 25, 2024 10:52am

@shoom3301 shoom3301 merged commit 22b8f89 into develop Dec 25, 2024
13 checks passed
@shoom3301 shoom3301 deleted the fix/make-e2e-great-again branch December 25, 2024 11:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2024
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants