feat(usd): further refactor SpotPrice updater #5297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use UsdPriceUpdater instead of triggering new requests from here
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
elena-zh
approved these changes
Jan 16, 2025
|
LGTM (with the new fix) |
|
Please post merge review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use UsdPriceUpdater instead of triggering new requests from here
I realized that there was still duplication and I could re-use the same method of fetching USD values we already have instead of triggering new requests every where
In this change, I added
useUsdPrices, that adds the required currency to the UsdPriceUpdater queue and used it on SpotPriceUpdaterTo Test