feat(market-price): use spot price for LIMIT market price button #5301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
|
Build failed 😠 |
elena-zh
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Hey @alfetopito , great, thank you!
But there is something definitely wrong with prices when I pick tokens with different decimals in the fields. See:
Arbitrum:
Base:
Gnosis chain:
Ethereum:
alfetopito
force-pushed
the
feat/market-price
branch
from
04ca893 to
a75484f
Compare
elena-zh
approved these changes
Jan 16, 2025
alfetopito
force-pushed
the
feat/market-price
branch
from
a75484f to
7b6fc7c
Compare
|
Please post merge review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #5297
Using spot price (from BFF USD estimations) to populate the
market pricebutton in the limit orders form.It's easier to see in the new design, but since it's independent from the changes there I'm piping into develop to add there later.
This is being removed to match exactly what's shown in the table
To Test