feat: hide orders table widget #5303
Merged
+28
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
elena-zh
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Hey @fairlighteth , thank you!
The only one issue that I face is that 'My orders' button has become not clickable. But it is reported in a separate task
alfetopito
approved these changes
Jan 16, 2025
Comment on lines
-30
to
+36
| display: ${({ isUnlocked }) => (isUnlocked ? '' : 'none')}; | ||
| display: ${({ isUnlocked }) => (!isUnlocked ? 'none' : '')}; |
There was a problem hiding this comment.
"Trocou 6 por meia dúzia", is what I have to say about this change
There was a problem hiding this comment.
Let me explain: https://crossidiomas.com/trocar-seis-por-meia-duzia/
There was a problem hiding this comment.
Pluuuus, unlock means not locked, so effectivelly reads worse: "not not lock: double negations are harder to reason about
alfetopito
force-pushed
the
feat/limit-ui-upgrade-13
branch
from
02cbfe4 to
f449a1d
Compare
alfetopito
force-pushed
the
feat/limit-ui-upgrade-14
branch
from
cd1bc6c to
260aad0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix orders table visibility in widget mode
Improved how we handle the
hideOrdersTableparameter in widget mode to ensure proper hiding of the orders table in both Limit Orders and TWAP pages:SecondaryWrapperbased onhideOrdersTableparameterPageWrappergrid template areas to adjust layout when table is hidden:This change ensures the orders table is properly hidden in widget mode while maintaining a clean layout structure.
Testing
hideOrdersTable=true