Allow change network standalone widget #5306
Open
+50
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alfetopito
approved these changes
Jan 17, 2025
Comment on lines
+52
to
+58
| {!!hideNetworkSelector && | ||
| standaloneMode !== false && | ||
| account && | ||
| !isChainIdUnsupported && | ||
| userEthBalance && | ||
| chainId && | ||
| !isUpToLarge && ( |
There was a problem hiding this comment.
These conditions are getting out of hand.
How about a variable/fn to abstract it away?
There was a problem hiding this comment.
I cannot agree more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The widget is currently not showing the network selector. For dapp mode, is not a big deal, because the connection is handled by the dapp, and therefore, the responsibility of the network is there too.
However, in standalone mode, there's not currently a way to change network.
Screen.Recording.2025-01-16.at.21.07.11.mov
This PR does 2 things:
Adds the setting in the configurator
Replaces the ETH balance by the network selector
ETH can be seen already in the network selector, and we are short on space. Plus we are a "gassless" exchange, you shouldn't need Ether a lot :)
So I took the space of the ETH to show the network:
