Enhance iOS UI, Unify Styling, and Disable Global USD Mode #5309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: hide orders table widget * feat: hide orders table widget for limit and twap
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
Addressed in this PR |
shoom3301
reviewed
Jan 22, 2025
apps/cowswap-frontend/src/modules/limitOrders/containers/TradeRateDetails/index.tsx
Outdated
Show resolved
Hide resolved
shoom3301
reviewed
Jan 22, 2025
apps/cowswap-frontend/src/modules/ordersTable/pure/OrdersTableContainer/OrdersTabs.tsx
Outdated
Show resolved
Hide resolved
shoom3301
reviewed
Jan 22, 2025
| @@ -39,7 +39,8 @@ import { WrapFlowActionButton } from '../WrapFlowActionButton' | |||
| const scrollToMyOrders = () => { | |||
| const element = document.getElementById(MY_ORDERS_ID) | |||
| if (element) { | |||
| element.scrollIntoView({ behavior: 'smooth' }) | |||
| const elementTop = element.getBoundingClientRect().top + window.scrollY - 76 | |||
There was a problem hiding this comment.
Need comments here, what 76 does mean?
There was a problem hiding this comment.
Addressed this. This is the sticky header offset. Made more obvious by moving to const with a comment.
shoom3301
reviewed
Jan 22, 2025
apps/cowswap-frontend/src/modules/trade/pure/TradePageLayout/index.tsx
Outdated
Show resolved
Hide resolved
Base automatically changed from
feat/limit-ui-upgrade-15
to
feat/limit-ui-upgrade
January 23, 2025 07:34
…l/cowswap into feat/limit-ui-upgrade-16 # Conflicts: # apps/cowswap-frontend/src/modules/ordersTable/pure/OrdersTableContainer/OrderRow/index.tsx
…RateDetails/index.tsx Co-authored-by: Alexandr Kazachenko <[email protected]>
…ndex.tsx Co-authored-by: Alexandr Kazachenko <[email protected]>
shoom3301
approved these changes
Jan 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Mobile & iOS Enhancements
UI & Styling Updates
RateInfo,OrderProgressBarV2, row elements) to standardize props and remove extra logic (e.g.withTimelineDot).Feature Toggles & Visibility
Miscellaneous Fixes
Overall, these changes streamline the codebase, improve mobile/iOS usability, refine UI behaviors, and disable unneeded features for a cleaner user experience.