refactor: decompose OrderRow component #5335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alfetopito
approved these changes
Jan 24, 2025
apps/cowswap-frontend/src/modules/ordersTable/pure/CurrencyAmountItem/index.tsx
Show resolved
Hide resolved
anxolin
reviewed
Jan 24, 2025
| {...props} | ||
| /> | ||
| ) | ||
|
|
||
| const renderLimitPrice = () => ( |
There was a problem hiding this comment.
Should we remove renderWarningEstimatedPrice too?
anxolin
reviewed
Jan 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please, review this PR commit by commit.
OrderRowto containers since this component became complex enough and it doesn't make sense to pass all the required data through props. It's just a relocation, no real changes right now, I will do it in the next PRs.OrderRowshowIconprop fromWarningTooltipThe goal of the refactoring is to get rid of excessive rerenders.
Main cause of them is a lot of count of function that renders separate UI, like here.
To Test
No need to test now, since this is not final refactoring PR.