Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(safe-app): remove approval+order placement bundling recommendation #5393

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

alfetopito
Copy link
Collaborator

Summary

Remove bundling recommendation for approval+order placement

To Test

  1. Connect with Safe via WC
  2. On SWAP, Pick as sell a token that needs approval
  • Should no longer see the banner
  1. Repeat with LIMIT orders
  • Same result
  1. Repeat with Safe app and EOA/another wallet
  • Should not show any banner, as before

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Feb 5, 2025 0:06am
cowfi ✅ Ready (Inspect) Visit Preview Feb 5, 2025 0:06am
explorer-dev ✅ Ready (Inspect) Visit Preview Feb 5, 2025 0:06am
sdk-tools ✅ Ready (Inspect) Visit Preview Feb 5, 2025 0:06am
swap-dev ✅ Ready (Inspect) Visit Preview Feb 5, 2025 0:06am
widget-configurator ✅ Ready (Inspect) Visit Preview Feb 5, 2025 0:06am

@alfetopito alfetopito self-assigned this Feb 5, 2025
@alfetopito alfetopito requested review from a team February 5, 2025 11:54
Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, @alfetopito , thank you!

Just to mention, that still we show this message inside the Safe, but should not be a part of the task. Correct?
image

@shoom3301 shoom3301 merged commit 571029d into release/2025-02-04 Feb 5, 2025
12 of 13 checks passed
@shoom3301 shoom3301 deleted the fix/remove-safe-bundling-suggestion branch February 5, 2025 12:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
@alfetopito
Copy link
Collaborator Author

Great, @alfetopito , thank you!

Just to mention, that still we show this message inside the Safe, but should not be a part of the task. Correct? image

Correct, that still remains

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
RELEASE Included in the release that is being closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants