fix(price-impact): show price impact exact % #5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
elena-zh
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Hey @alfetopito , thank you for addressing this!
As a nitpick, I'd make the percentage in bold to add more visibility for it.
Like we do here, as an example
shoom3301
approved these changes
Feb 6, 2025
anxolin
approved these changes
Feb 6, 2025
Yeah, the way it's implemented there's not really an easy solution. |
alfetopito
force-pushed
the
fix/show-pctg-high-price-impact
branch
from
3d999bb to
46f06e5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tiny change to make the actual percentage in the price impact displayed when confirming it:
To Test