Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Reusable Code to dune-client #40

Open
3 tasks
bh2smith opened this issue Nov 17, 2022 · 0 comments
Open
3 tasks

Migrate Reusable Code to dune-client #40

bh2smith opened this issue Nov 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@bh2smith
Copy link
Contributor

Several pieces introduced in #37 can be refined, generalized and moved into the dependency package dune-cli

In particular:

There are a few reasons why these have not yet been moved into the client outlined here. But, in essence, it is because they need to be refined a bit more before we can make then serve as a useful general purpose. For example, it isn't clear that either of QueryData or DuneFetcher are all that beneficial -- perhaps its better to just extend the Query and DuneClient classes to include the additional fields added in these "extended classes". Would love to open up a discussion about this (maybe in the Dune Client).

@bh2smith bh2smith added the enhancement New feature or request label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant