Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Last Sync - Improvements #16

Open
bh2smith opened this issue Dec 7, 2022 · 0 comments
Open

Last Sync - Improvements #16

bh2smith opened this issue Dec 7, 2022 · 0 comments

Comments

@bh2smith
Copy link
Contributor

bh2smith commented Dec 7, 2022

@MartinquaXD raised some good (non-blocking) points of improvement for the already merged code in #12. Here I will try to summarize;

  1. No need for Optional Block Number. This is only used for testing purposes and the tests could be adapted instead of the return type.
  2. Throw error on invalid table name. I think the problem with this may be that our test tables write to a different directory (intentionally) so not to interfere with real data. I think we may want to keep this.... not sure.
  3. Look at when KeyError occurs
  4. Use Contract Deployment as default genesis block

I think items 1 and 4 are the most straight forward to change first, still not sure yet about the other two.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant