Skip to content

Commit

Permalink
Increase threshold for combinatorial auction test (#111)
Browse files Browse the repository at this point in the history
At the moment, the combinatorial auction test generates non-actionable
alerts.

The original threshold of `0.001 ETH` is not large enough to avoid false
positives due to, e.g., inaccurate fee estimates. The new threshold of
`0.005 ETH` is more in line with other thresholds used.

Midterm we could also remove the test or redesign it to have less
overlap with the competition surplus test.
  • Loading branch information
fhenneke authored Jun 20, 2024
1 parent 66841a8 commit 97d0d8f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
SURPLUS_REL_DEVIATION = 0.004

# combinatorial auctions
COMBINATORIAL_AUCTION_ABSOLUTE_DEVIATION_ETH = 0.001
COMBINATORIAL_AUCTION_ABSOLUTE_DEVIATION_ETH = 0.005

# cost coverage test
COST_COVERAGE_ABSOLUTE_DEVIATION_ETH = 0.01
Expand Down

0 comments on commit 97d0d8f

Please sign in to comment.