From c9a5d2b5dc082f9e787d8dba1ce4dd15d1d177e3 Mon Sep 17 00:00:00 2001 From: Felix Henneke Date: Fri, 14 Jul 2023 13:52:41 +0200 Subject: [PATCH] Change handling of quasimodo error (#66) If quasimodo does not return a valid response, instead of emitting an error and retrying a hash, we now emit a warning and do not try the hash again. This is just a hotfix. To solve the underlying issue, we should - add error handling using custom exceptions - let tests fail gracefully by removing hashes after some retries - find the bug in how we call quasimodo --- src/monitoring_tests/reference_solver_surplus_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/monitoring_tests/reference_solver_surplus_test.py b/src/monitoring_tests/reference_solver_surplus_test.py index 2da5070..baa97d3 100644 --- a/src/monitoring_tests/reference_solver_surplus_test.py +++ b/src/monitoring_tests/reference_solver_surplus_test.py @@ -54,11 +54,11 @@ def compare_orders_surplus( trade_alt = self.get_trade_alternative(uid, auction_instance) if trade_alt is None: - self.logger.error( + self.logger.warning( f"No alternative trade for uid {uid} and " f"auction id {auction_instance['metadata']['auction_id']}" ) - return False + return True if trade_alt.execution.buy_amount == 0: continue