Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abstraction for EBBO test #32

Open
fhenneke opened this issue Apr 24, 2023 · 0 comments
Open

Fix abstraction for EBBO test #32

fhenneke opened this issue Apr 24, 2023 · 0 comments
Assignees

Comments

@fhenneke
Copy link
Contributor

On thing that is not yet clear to me is what the correct abstraction for the EBBO test should be.
Generally I think we should compare buy and sell amounts of an executed order with buy and sell amounts of alternative executions.

The buy and sell amounts for the executed order can always be read from on chain data. The buy and sell amount for alternative executions can be obtained differently. Examples for alternative executions include solutions proposed by other solvers and solutions computed after the fact by Quasimodo or other solvers.

This would mean that the different EBBO test would differ in how they compute buy and sell amounts. They could then use the same code for the comparison itself.

@harisang harisang changed the title Fix abstracton for EBBO test Fix abstraction for EBBO test Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants