Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mev Blocker kickbacks alert #81

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Add Mev Blocker kickbacks alert #81

merged 7 commits into from
Nov 6, 2023

Conversation

harisang
Copy link
Contributor

@harisang harisang commented Nov 2, 2023 •
edited
Loading

This PR adds a test that monitors for MEV Blocker kickbacks, and generates an alert if a large enough kickback is received. This is a follow-up PR on PR #79

@harisang harisang requested a review from fhenneke November 2, 2023 13:09
fhenneke
fhenneke requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to run that locally. In the repo on my computer this does not include the latest changes of main and thus does not have access to the new get_eth_transfers_by_block_range functionality. I could rebase locally but I wonder how you (or github via pylint) tested this branch.

src/constants.py Show resolved Hide resolved
src/monitoring_tests/mev_blocker_kickbacks_test.py Outdated Show resolved Hide resolved
@harisang harisang force-pushed the add_mev_blocker_kickbacks_alert branch from d40ee04 to 6c11247 Compare November 2, 2023 20:32
@harisang
Copy link
Contributor Author

harisang commented Nov 2, 2023

Not sure how to run that locally. In the repo on my computer this does not include the latest changes of main and thus does not have access to the new get_eth_transfers_by_block_range functionality. I could rebase locally but I wonder how you (or github via pylint) tested this branch.

Could you try again? Just did a rebase.

fhenneke
fhenneke approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the code for hash 0xa8c5fae2995d74b2a5738b588aa758831b818f21bb283124a8c8c80f813bedec and the results coincide with what I get in this dune query.

LGTM.

src/constants.py Show resolved Hide resolved
@harisang harisang merged commit 937363c into main Nov 6, 2023
3 checks passed
@harisang harisang deleted the add_mev_blocker_kickbacks_alert branch November 6, 2023 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fhenneke fhenneke fhenneke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harisang @fhenneke