[CIP-38] Add Uniform Directional Clearing Prices test #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a |
- renamed token_pairs to directional_prices - use min function to determine minimal exchange rate - add info to log message, and also log for smaller deviations - use Fractions to be compatible with backend code
|
I tested the code with the two hashes |
|
I just realized that we might need to change the code later to correctly account for protocol fees. They need to be used to correct directional prices. Since there is no way at the moment to get fee policies via the API, we should fix it later. Doing it for the launch tomorrow will not work in time. |
fhenneke
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check for the UDP rule, as introduced in CIP-38.