Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protocol (and integrator) fee to uniform directional price test #98

Open
fhenneke opened this issue Mar 18, 2024 · 0 comments
Open

Comments

@fhenneke
Copy link
Contributor

Under CIP-38, we need to check for directional prices. The implementation in #97 does not account for protocol fees. Per the CIP those fees do enter the rule on directional price.

The main blocker for implementing this is availability of protocol fee information from the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant