Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ethereum Waffle artifact support. #382

Open
nlordell opened this issue Sep 24, 2020 · 1 comment
Open

Add Ethereum Waffle artifact support. #382

nlordell opened this issue Sep 24, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nlordell
Copy link
Contributor

nlordell commented Sep 24, 2020 •
edited
Loading

We currently only have support for Truffle artifacts, and raw ABIs, it would be nice to also support Ethereum Waffle artifacts for things like deployment transaction and address for networks.

@josojo This is relevant for gnosis/oba-services
@fleupold fleupold mentioned this issue Dec 8, 2020
Merged
fleupold added a commit to gnosis/gp-v2-services that referenced this issue Dec 8, 2020
@fleupold
[Easy] Add GPv2Contract artefact (#91)
02dc58f 
This PR adds the dependencies for GPv2 Settlement. Note, that part of the change accidentally slipped in to a hot fix I applied last week when trying to get autodeploy running (7213878)

Given the setup of hardhat (which has separate jsons for each network) we are currently specifically importing the rinkeby artefact. We also cannot automatically load the deployed address as hardhat's .json is slightly different from truffle's. Given that this is the same for the Uniswap contract it might be ok to simply define the contract addresses in code somewhere (there is also cowprotocol/ethcontract-rs#382 tracking ethers support in ethcontracts).

### Test Plan
Depending on the new contract in main works (if we add contracts to the solver's Cargo.toml)
@nlordell nlordell added enhancement New feature or request good first issue Good for newcomers labels May 17, 2021
@nlordell nlordell changed the title Add ethers artifact support. Add Ethereum Waffle artifact support. Jun 21, 2021
@taminomara
Copy link
Contributor

From what I see, Truffle and Waffle use the same format?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlordell @taminomara