Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardhat support probably shouldn't depend on hardhat-deploy #731

Open
banshee opened this issue Mar 4, 2022 · 1 comment
Open

Hardhat support probably shouldn't depend on hardhat-deploy #731

banshee opened this issue Mar 4, 2022 · 1 comment

Comments

@banshee
Copy link

banshee commented Mar 4, 2022

Looking at the hardhat config in examples/hardhat/hardhat.config.js, you start with:

require("hardhat-deploy");

That seems a bit unusual; we certainly use hardhat, but we took a quick look at hardhat-deploy and decided it wasn't necessary. I guess it makes sense to support hardhat-deploy in addition to the mainstream, but it shouldn't be a requirement.

@banshee
Copy link
Author

banshee commented Mar 4, 2022

Looking deeper at the code, I think the hardhat support is just misnamed; it's really support for hardhat-deploy and not for hardhat at all. Things like fn _load_from_directory talk about directory structures that are completely different from normal hardhat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant