-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epic] 4.2: Protocol Fee Implementation #29
Comments
Why solvers (I mean matching engines or AFAIU, all needed changed are done in the |
Is it for all TWAP orders (in-market and out-of-market price)? If so, how do I differentiate between regular in-market limit order and in-market TWAP order, since AFAIS, there is nothing that marks limit order and says that is originated from TWAP module? |
After the grooming with solver team, the first issue (adjusting the clearing prices for service/protocol fee) would look like this:
If we observe the settlement onchain from the autopilot, while also having the original quote and protocol_fee_factor, by going in reverse we should be able to reconstruct the values for protocol fee and surplus fee. |
Since we are introducing 0 fee model, technically speaking, all in-market orders will be limit orders, right? So we just need to be able to distinguish between Limit in-market and out-of-market orders and TWAP orders in general. Twap orders have a flag.
Would in this case, the extra funds (the fee) stay with CoW DAO directly, or will it first go to the solver, and then we have to claim it back? |
They would stay in the settlement contract which means we would control them. |
Here are some ideas around the processing of auctions to charge protocol fees from surplus. (You can ignore most stuff at the top of the document.) |
Epic label:
E:...
Planned start date: 08/12/2023
Due date:
Summary
This current task requires configuring drivers (or solvers - TBD) for the successful fee implementation. The quote must pass the decision whether the fee is applicable for the current order or not, then, the fixed parameters will be applied for the fee calculation after the order is executed. Finally, we need to decide how we collect the payment from the solvers (weekly with the payouts, in COW or other).
Iteration 1:
Additional requirements:
Acceptance Criteria
Tasks
Breakdown of the work
The text was updated successfully, but these errors were encountered: