Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Incorrect Score For Certain Settlements #1951

Closed
nlordell opened this issue Oct 12, 2023 · 1 comment · Fixed by #1953
Closed

bug: Incorrect Score For Certain Settlements #1951

nlordell opened this issue Oct 12, 2023 · 1 comment · Fixed by #1953
Assignees
@fhenneke @MartinquaXD
Labels
bug Something isn't working E:3.1 Driver Colocation See https://github.com/cowprotocol/pm/issues/14 for details

Comments

@nlordell
Copy link
Contributor

Problem

Scores are completely wrong (for example, we had a score of 27 ETH for a settlement with small arbitrage orders).
@nlordell nlordell added bug Something isn't working E:3.1 Driver Colocation See https://github.com/cowprotocol/pm/issues/14 for details labels Oct 12, 2023
@fleupold
Copy link
Contributor

Example: https://barn.api.cow.fi/mainnet/api/v1/solver_competition/9079199

@fleupold fleupold mentioned this issue Oct 12, 2023
Open
5 tasks
@sunce86 sunce86 mentioned this issue Oct 12, 2023
Merged
sunce86 added a commit that referenced this issue Oct 12, 2023
@sunce86
Fix score deserialization (#1953)
30825ed 
# Description
Fixes #1951

The issue was that the decimal was interpreted as hex, so decimal
`16442840735913131` becomes `25671225992463593777 `
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhenneke fhenneke

@MartinquaXD MartinquaXD

Labels
bug Something isn't working E:3.1 Driver Colocation See https://github.com/cowprotocol/pm/issues/14 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix score deserialization cowprotocol/services
4 participants
@fleupold @nlordell @fhenneke @MartinquaXD