Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove the out-of-market flagging as liquidity orders #2057

Closed
harisang opened this issue Nov 14, 2023 · 3 comments
Closed

feat: Remove the out-of-market flagging as liquidity orders #2057

harisang opened this issue Nov 14, 2023 · 3 comments

Comments

@harisang
Copy link
Contributor

Problem

It seems we continue to flag orders as liquidity orders when they are "out of market". At some point in time, this was meaningful, but I think it is not anymore, and it might lead to problematic flagging of orders. See here for an example and discussion.

Suggested solution

Remove this "rule", effectively reverting PR #301

Copy link

github-actions bot commented Feb 7, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@MartinquaXD
Copy link
Contributor

@sunce86 didn't we have an issue that says we want to get rid of the concept of liquidity orders altogether. I wanted to link it here but can't find it. Do you know where it is?

@sunce86
Copy link
Contributor

sunce86 commented Feb 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants