Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deadline should be a query parameter #2232

Closed
marcovc opened this issue Jan 1, 2024 · 1 comment
Closed

feat: deadline should be a query parameter #2232

marcovc opened this issue Jan 1, 2024 · 1 comment

Comments

@marcovc
Copy link
Contributor

marcovc commented Jan 1, 2024

Problem

I'd like you to give a second thought about the idea of adding the deadline as part of the instance data. I agree that ideally, an instance should contain everything a solver needs to know to solve an instance. However, there is also the issue of replication: we would like to run the same instance later for debugging, backtesting, etc. So having a hardcoded deadline means that the solver will instantly time out because that time will be in the past.

Suggested solution

The idea of going from time limit to deadline is great, but I am not fan of adding it to the json. I think this a good example solved by a query parameter.

Alternatives

  • Add yet another parameter to the solver --ignore-time-limit-in-the-auction-file, and then another --time-limit to force a time limit.
  • Bump the time-limit if it is the past. I had some issues with instances arriving at my node already after the time limit, so I don't think this is a good idea.
Copy link

github-actions bot commented Mar 2, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant