bug: OrderEventLabel::Traded does not get stored reliably

[MartinquaXD]

Problem

Currently we store OrderEventLabel::Traded after the autopilot's /settle call returned successfully.
But it's possible that the call times out or the called driver has some other issue which would result in the Traded event not being stored although the order was settled.

Impact

This has no impact on the user because the order events labels are just for debugging purposes but it can show false negatives in the Time to Happy Moo SLI dashboard that analyzes this data.

To reproduce

Probably enough to use an existing e2e test that settles an order with a temporary patch to the driver that returns an error after the /settle handler saw the successfully submitted tx.

Expected behaviour

We should have a Traded event even if the /settle call returned some error if the order was in fact traded on chain regardless.

Additional context

logs where that issue happened for this order which was settled in this tx
One option to tackle this would be to move the logic that stores the Traded events into the logic that runs during event indexing. That way we'll for sure get the event.

[github-actions]

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.