Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement PriceImprovement over Quote #2266

Closed
sunce86 opened this issue Jan 11, 2024 · 2 comments
Closed

feat: Implement PriceImprovement over Quote #2266

sunce86 opened this issue Jan 11, 2024 · 2 comments
Assignees

Comments

@sunce86
Copy link
Contributor

sunce86 commented Jan 11, 2024

Problem

#2213 (comment)

Here we discussed if the current implementation of the protocol fee should be called PriceImprovement, since price improvement is usually related to either limit price or market price at order creation time, whichever is higher/lower for sell/buy order.
Right now, implementation exist only as an improvement over limit price.

This issue captures work of taking Quote into consideration when calculating protocol fee (PriceImprovement case).

If by any chance we decide not to implement this, before closing this issue we should rename the PriceImprovement to Surplus or LimitPriceImprovement or similar.

@sunce86 sunce86 added the E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details label Jan 11, 2024
@squadgazzz squadgazzz self-assigned this Jan 12, 2024
@sunce86
Copy link
Contributor Author

sunce86 commented Jan 12, 2024

Since we renamed PriceImprovement to Surplus, we now need to add a new variant PriceImprovement which would have also factor and max_volume_factor, but also a quote.

@sunce86
Copy link
Contributor Author

sunce86 commented Jan 15, 2024

Since we renamed, closing this issue since now we have the tracker: #2287

@sunce86 sunce86 closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants