Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete bad token detection #2319

Open
MartinquaXD opened this issue Jan 23, 2024 · 6 comments
Open

chore: Delete bad token detection #2319

MartinquaXD opened this issue Jan 23, 2024 · 6 comments
Labels
E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details

Comments

@MartinquaXD
Copy link
Contributor

MartinquaXD commented Jan 23, 2024

Background

Bad token detection is a crutch needed when we are not able to verify quotes. Once we are confident in the quote verification logic we should delete it. Since this is also the only code we use trace_callMany we can also delete support for that.

One thing to look out for is that we'll probably experience higher load because we will be serving more tokens than before.

@MartinquaXD MartinquaXD added the E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details label Jan 23, 2024
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Mar 25, 2024
@fleupold
Copy link
Contributor

Not stale, just taking a bit longer than expected.

@fleupold fleupold removed the stale label Mar 25, 2024
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label May 25, 2024
@github-actions github-actions bot closed this as completed Jun 1, 2024
@mfw78 mfw78 reopened this Jun 1, 2024
@mfw78 mfw78 removed the stale label Jun 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Aug 1, 2024
@fleupold fleupold removed the stale label Aug 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Oct 1, 2024
@fleupold fleupold removed the stale label Oct 1, 2024
Copy link

github-actions bot commented Dec 1, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details
Projects
None yet
Development

No branches or pull requests

4 participants