Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Phase out PriceQuality::Verified #2322

Closed
MartinquaXD opened this issue Jan 23, 2024 · 3 comments
Closed

chore: Phase out PriceQuality::Verified #2322

MartinquaXD opened this issue Jan 23, 2024 · 3 comments
Labels
E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details

Comments

@MartinquaXD
Copy link
Contributor

With the backend trying to verify as many quotes as possible there is no reason to distinguish between Optimal and Verified anymore.

This PR tracks the work to phase out the verified variant. This is mostly a trivial code change in the backend but needs to be coordinated with the frontend so we don't discard quote requests due to deserialization errors.

@MartinquaXD MartinquaXD added the E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details label Jan 23, 2024
@fleupold
Copy link
Contributor

I think there may still be some value in this field. At least when sending the response back to the frontend it would be nice to indicate if the quote was verified (so that the frontend could show something to the user).

Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Mar 25, 2024
@fleupold fleupold removed the stale label Mar 25, 2024
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details
Projects
None yet
Development

No branches or pull requests

2 participants