Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Revert onchain_settlement e2e test #2578

Closed
sunce86 opened this issue Mar 29, 2024 · 1 comment
Closed

feat: Revert onchain_settlement e2e test #2578

sunce86 opened this issue Mar 29, 2024 · 1 comment

Comments

@sunce86
Copy link
Contributor

sunce86 commented Mar 29, 2024

Problem

Since Naive solver does not support limit orders, we had to remove the file onchain_settlement.rs in #2536

Once the support for Naive solver is added, we should revert this change.

#2536 (comment)
@sunce86 sunce86 mentioned this issue Mar 29, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label May 29, 2024
@github-actions github-actions bot closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunce86