Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Store auction instances including liquidity #2633

Closed
fhenneke opened this issue Apr 19, 2024 · 1 comment · Fixed by #2663
Closed

feat: Store auction instances including liquidity #2633

fhenneke opened this issue Apr 19, 2024 · 1 comment · Fixed by #2663
Assignees
Labels
team:solvers Issues / PRs scoped to solvers

Comments

@fhenneke
Copy link

Problem

Since switching solvers to the new auction format, auction instances from the driver (including liquidity) are not stored anymore. Since those instances have been used for EBBO testing, some EBBO checks are currently not working.

Since we want to move forward with formalizing EBBO, having auctions instances is required to get a better overview of the magnitude of EBBO violations.

Suggested solution

Store auction instances from one of the solvers which receives liquidity, similarly to how it was done for the legacy format. Auction instances from the autopilot are not enought since they do not contain liquidity.

@fhenneke fhenneke added the team:solvers Issues / PRs scoped to solvers label Apr 19, 2024
@fleupold
Copy link
Contributor

Here is a pointer to the code where this was done in the legacy solver implementation:

The s3::Uploader is already a shared crate and should be reusable in the driver. We should allow a per solver configuration to upload (different solvers could use different paths on the bucket) but in practice only enable uploading for Quasimodo.

@m-lord-renkse m-lord-renkse self-assigned this Apr 22, 2024
m-lord-renkse added a commit that referenced this issue Apr 30, 2024
# Description
Store auction instances from one of the solvers which receives
liquidity, similarly to how it was done for the legacy format. Auction
instances from the autopilot are not enough since they do not contain
liquidity.

## How to test
1. Regression tests
2. It can be tested in staging by configuring quasidomo and checking the
S3 bucket

Fixes #2633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:solvers Issues / PRs scoped to solvers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants