Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Solver solutions pre/post-interaction support #2636

Closed
squadgazzz opened this issue Apr 19, 2024 · 1 comment · Fixed by #2679
Closed

feat: Solver solutions pre/post-interaction support #2636

squadgazzz opened this issue Apr 19, 2024 · 1 comment · Fixed by #2679
Assignees
Labels
team:solvers Issues / PRs scoped to solvers

Comments

@squadgazzz
Copy link
Contributor

Excerpt from #2607

@squadgazzz squadgazzz added the team:solvers Issues / PRs scoped to solvers label Apr 19, 2024
@fleupold
Copy link
Contributor

I don't think JIT orders need to support pre-interactions per se. Instead, I think the solution that solvers return should allow them to specify pre and post interactions for the whole settlement (on top of the ones that are specified by each user order).

This would allow solvers to also invoke pre interactions without needing to specify a JIT order (not sure if there is a use case for it), but in any case any solver that is crafting a JIT order could also just attach its pre-interactions on the outer solution struct.

@squadgazzz squadgazzz self-assigned this Apr 29, 2024
@squadgazzz squadgazzz changed the title feat: JIT orders pre-interaction support feat: Solver solutions pre-interaction support May 1, 2024
@squadgazzz squadgazzz changed the title feat: Solver solutions pre-interaction support feat: Solver solutions pre/post-interaction support May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:solvers Issues / PRs scoped to solvers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants