-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow multiple solution submissions for one auction #2830
Comments
As for scope creep, can we agree that for the speed initiative we still want solvers to combine solutions as much as possible (that is each solver will only receive one settle call). I think this reduces scope and in the absence of the new fairness rule (which may disqualify batched bids) I don't think this is needed. |
I think the main thing I'm missing from a design perspective is how we are going to match solution candidates with settlement observations? If we told 3 solvers to settle and observe 2 settlements later on chain, how do we know which one is which? |
We can match on orders since no common tokens are allowed to exist among winning solutions. |
# Description A breaking change of SolverCompetitionAPI, which now potentially returns more than 1 transaction associated with the competition (will notify all teams on slack soon). Resolves one of the points from #2830 (comment) # Changes <!-- List of detailed changes (how the change is accomplished) --> - [ ] SolverCompetitionAPI now returns `Vec<TransactionHash>`, instead of `Option<TransactionHash>` ## How to test Refactored unit test to prove it works and that no regression issues were introduced. Existing e2e test for solver competition proves that competition is properly returned.
Closing as implemented. |
Problem
We frequently see competing solutions in which some orders are matched in the first and some other orders are matched in the other solution. Currently we chose the single best solution from all candidate, potentially leaving order that had been matched unsettled. This can cause delay and increase the user's "time to happy moo"
Suggested solution
Allow mutually exclusive solutions (ie solutions that don't overlap in any order) to be settled in the same auction.
Additional context
This will have non-trivial impact on other parts of the protocol (e.g. solver payouts) so we should proceed with a lot of care. Maybe we can first experiment with this in sepolia to see which parts of the existing backend system would break and then coordinate with the remaining teams to see if there are issues with also enabling this in prod.
Acceptance criteria
There should be a way to configure the maximum number of solutions that can be settled per auction (default to 1 like today). If set to more than one, the top n solvers should receive a
settle
call.Settlement indexing and all other post trade features (fetching trades, solutions, etc) should be working no n>1 as it is today.
The text was updated successfully, but these errors were encountered: