Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add surplus capturing JIT order data to /solve response #2839

Closed
sunce86 opened this issue Jul 25, 2024 · 2 comments · Fixed by #2984
Closed

feat: Add surplus capturing JIT order data to /solve response #2839

sunce86 opened this issue Jul 25, 2024 · 2 comments · Fixed by #2984

Comments

@sunce86
Copy link
Contributor

sunce86 commented Jul 25, 2024

Problem

As stated in #2730 (comment):

Now that cow amm orders are surplus capturing, they are also part of the /solve response, but autopilot doesn't know all necessary data for these orders to build the settlement::Solution and consequently Score AT COMPETITION TIME. The solution would be to expand /solve response with sell_token, sell_amount, but_token, buy_amount, side. With that, score could be calculated.

So, since JIT orders are invisible to autopilot before being settled onchain, if we want to do anything with them at COMPETITION time (verify score, surplus, whatever), we need to add some more data to /solve response.

@fleupold
Copy link
Contributor

Can this be closed?

@sunce86
Copy link
Contributor Author

sunce86 commented Sep 12, 2024

Can this be closed?

We added surplus capturing JIT orders to solve response but we still miss "sell_token, sell_amount, but_token, buy_amount, side" for each surplus capturing JIT order to unblock #2730.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants