Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Exclude CoW AMMs with zero liquidity #2846

Closed
squadgazzz opened this issue Jul 30, 2024 · 0 comments · Fixed by #2849
Closed

chore: Exclude CoW AMMs with zero liquidity #2846

squadgazzz opened this issue Jul 30, 2024 · 0 comments · Fixed by #2849
Assignees

Comments

@squadgazzz
Copy link
Contributor

@harisang noticed that empty CoW AMMs produce division or modulo by zero while constructing an order.
As @fleupold suggested, a maintenance job can be created here, which on every block checks all the balances of the tokens that the AMM is supposed to hold and remove it from Storage if one of its balances reaches 0.

@squadgazzz squadgazzz self-assigned this Jul 30, 2024
@squadgazzz squadgazzz mentioned this issue Jul 31, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant