chore: Stop using string for solution_id #3072
Comments
Merged
sunce86
added a commit
that referenced
this issue
Oct 18, 2024
# Description Related to #3064 This PR enables driver to send either string or integer for `solution_id`. This PR marks the start of transition period. Once the PR is merged, external solvers will be asked to: 1. Start sending `solution_id` as integer in `/solve` response. 2. Implement receiving either string or integer for `solution_id` on `/reveal` and on `/settle`. Once done, backend will have a [follow up](#3072) where we will definitely switch to using integers in all three endpoints and #3064 will be fixed. ## How to test Manually checked that both versions are properly serialized/deserialized. <!-- ## Related Issues Fixes # -->
|
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
A cleanup task that should follow up after #3071, once solvers switched to using integers.
/reveal and /settle calls should be adjusted to use integers and /solve deserialization cleanup up.
The text was updated successfully, but these errors were encountered: