Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be consistent on getOrCreate functions #44

Open
GabrielCamba opened this issue Jun 22, 2022 · 0 comments
Open

Be consistent on getOrCreate functions #44

GabrielCamba opened this issue Jun 22, 2022 · 0 comments
Assignees
@GabrielCamba
Labels
Protofire Subgraph Subgraph related task

Comments

@GabrielCamba
Copy link
Contributor

@anxolin pointed out getOrCreate functions are not consistent.
Some of them are creating and saving the entity and some of them are creating the entity and returning for being saved by the caller function.

Let's find a convention for that to be more explicit.
@GabrielCamba GabrielCamba added Protofire Subgraph Subgraph related task labels Jun 22, 2022
@GabrielCamba GabrielCamba self-assigned this Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GabrielCamba GabrielCamba

Labels
Protofire Subgraph Subgraph related task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GabrielCamba