Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in tokens for price feed #78

Open
fhenneke opened this issue Oct 14, 2024 · 0 comments
Open

Bug in tokens for price feed #78

fhenneke opened this issue Oct 14, 2024 · 0 comments

Comments

@fhenneke
Copy link
Contributor

Just saw this comment and in particular

The writing in the new tables is also based in the token imbalances token list, as this is more efficient (as we do not need prices for tokens with an imbalances of exactly zero).

This is not correct as imbalances do not account for network fees and protocol fees. Thus we need prices for them as well if we want to reproduce our current accounting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant